Skip to content

raise an exception when unauthorized#19

Merged
solarkennedy merged 1 commit into
masterfrom
handle-auth
Dec 23, 2015
Merged

raise an exception when unauthorized#19
solarkennedy merged 1 commit into
masterfrom
handle-auth

Conversation

@Rob-Johnson
Copy link
Copy Markdown
Collaborator

fixes #17 - raise an exception when the request is unauthorized rather than returning the HTML.

@solarkennedy
Copy link
Copy Markdown
Collaborator

Looks good. Too bad we are not using requests and just using raise_for_status so we don't have to reinvent every status code exception?

solarkennedy added a commit that referenced this pull request Dec 23, 2015
raise an exception when unauthorized
@solarkennedy solarkennedy merged commit 1473f6d into master Dec 23, 2015
@solarkennedy solarkennedy deleted the handle-auth branch January 2, 2016 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Client doesn't deal with unauthorized access correctly

2 participants